Feature caching fix #357

Pwhsky · 2025-07-03T09:08:45Z

This small PR contains an added typecheck and _ID check as described in issue #352

Update test_features.py Update features.py Update test_features.py Update features.py

This fixed the issue of not being able to call the feature with ().

giovannivolpe · 2025-07-04T08:54:03Z

It doesn't pass unit test. Strange behavior with test_statistic.test_broadcast_list(). Please, check carefully

giovannivolpe added 30 commits June 18, 2025 20:32

Update features.py

381630d

Update features.py

c6132f4

Update features.py

4b68ce1

Update features.py

21044e8

Update test_features.py

0f55b17

Update features.py

017f21e

Value

3e4a546

Update test_features.py Update features.py Update test_features.py Update features.py

Update test_features.py

83bb491

remove __gpu_compatible__

8851004

Update features.py

c806cfd

Update test_features.py

a1f71d7

Update features.py

b1ca6ca

Update test_features.py

0a78b0f

Update aberrations.py

2ea065b

Update optics.py

d1b8d34

Update image.py

84fecbd

Update holography.py

6eafa18

Update features.py

addebc9

Update features.py

15cdd3c

Update test_features.py

ef06761

Update features.py

c8b3df6

Update test_features.py

17e3921

Update features.py

83a3566

Update test_features.py

158f247

Update features.py

00533aa

Update test_features.py

910dae0

Update features.py

755e09b

Update features.py

046b6e2

Update features.py

0c83f7c

Update features.py

b2da196

giovannivolpe and others added 23 commits July 1, 2025 19:14

Update features.py

fffdf6d

Update features.py

df8330f

Update features.py

57e42ec

Update features.py

e4e9750

Update features.py

4355a71

Update features.py

55d6788

Update features.py

a55e95f

Update features.py

b247a65

Update features.py

2c61e9f

Update features.py

434d661

Update features.py

c356091

Update features.py

f790513

Update features.py

c05ca7a

Update features.py

9b42746

Update features.py

bb709db

Update features.py

d5920c8

Update features.py

d28a829

Update features.py

50491da

Update features.py

a969692

Update features.py

1320523

Update features.py

adaa426

Update _config.py

7d2379f

Added image_list typecheck and _ID check

48cc256

Pwhsky requested review from cmanzo and BenjaminMidtvedt July 3, 2025 09:11

Uses input(_ID) instead of input.current_value(_ID)

e648f9f

This fixed the issue of not being able to call the feature with ().

Pwhsky added 2 commits July 4, 2025 14:32

now checks _ID with .is_valid()

73c850d

added elif

64b68e0

Base automatically changed from gv/final/features to develop July 11, 2025 15:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Feature caching fix #357

Feature caching fix #357

Pwhsky commented Jul 3, 2025 •

edited

Loading

Uh oh!

giovannivolpe commented Jul 4, 2025

Uh oh!

Uh oh!

Feature caching fix #357

Are you sure you want to change the base?

Feature caching fix #357

Conversation

Pwhsky commented Jul 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

giovannivolpe commented Jul 4, 2025

Uh oh!

Uh oh!

Pwhsky commented Jul 3, 2025 •

edited

Loading